allow importing bun.lock (+ types for it)
#16244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfgithub
reviewed
Jan 8, 2025
dylan-conway
reviewed
Jan 9, 2025
DonIsaac
reviewed
Jan 11, 2025
cirospaciari
pushed a commit
that referenced
this pull request
Jan 13, 2025
Co-authored-by: RiskyMH <[email protected]>
paperclover
pushed a commit
that referenced
this pull request
Jan 14, 2025
Co-authored-by: RiskyMH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows you to
import lockfile from "./bun.lock"and also provides types (to hopefully help 3rd parties understand it). Also adds extension.jsoncthat ignores comments too.I believe the typescript is good, I have tried it myself but maybe I'm being too strict.
How did you verify your code works?
Will add tests